Matter Energy: Fix non- JSON serializable fields #2418
Merged
+33
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 71 files 455 suites 0s ⏱️ Results for commit 2450afd. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2450afd |
ctowns
reviewed
Sep 22, 2025
hcarter-775
reviewed
Sep 30, 2025
hcarter-775
reviewed
Sep 30, 2025
hcarter-775
approved these changes
Sep 30, 2025
nickolas-deboom
force-pushed
the
matter-energy-fix-non-json-serializable-fields
branch
from
abc9d86 to
2f36114
Compare
Tested with Battery Storage, Solar Power, and EVSE device types. Everything works fine except energyMeter is not populated because of read failures from the VDA for ElectricalEnergyMeasurement. Since this is a VDA issue, the behavior is the same on the production driver and the issue is unrelated to this change. |
gharveymn
approved these changes
Oct 9, 2025
Keys in datastore tables need to be strings in order to be JSON serializable. SUPPORTED_EVSE_MODES_MAP and SUPPORTED_DEVICE_ENERGY_MANAGEMENT_MODES_MAP need to be updated.
nickolas-deboom
force-pushed
the
matter-energy-fix-non-json-serializable-fields
branch
from
20b655b to
2450afd
Compare
nickolas-deboom
deleted the
matter-energy-fix-non-json-serializable-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys in datastore tables need to be strings in order to be JSON serializable.
SUPPORTED_EVSE_MODES_MAPandSUPPORTED_DEVICE_ENERGY_MANAGEMENT_MODES_MAPneed to be updated.